Repository navigation
Adopt released OpenCL helpers for safer buffers and optional loading - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An OpenCL-enabled build currently links the loader at process startup, chooses the first enumerated device, and releases old buffers before allocating replacements. Adopt the released OpenCL 1.1.0 helpers so device selection checks availability/compiler support, scratch growth preserves existing storage on failure, and newly created scratch owners are cleaned up if dispatch fails.
Document and test a dynamically loaded build that starts without OpenCL and uses the deterministic CPU fallback. Keep GPU preference, the existing scan kernels, CPU verification and stable entity ordering. Keep Vulkan 3.2.2 to match the allocator's transitive pin; Vulkan 3.3.0 is published separately for future instrumentation work.
Validation: full local check.sh passed (simulation/runtime tests, deterministic checksums, OpenCL, Vulkan startup, keyboard/replay UI); the OpenCL sim suite passed with compiler fallback disabled. Focused cleanup and reservation tests pass. Dynamic GCC and TinyCC runs preserve all seven checksums with a working loader and a deliberately missing loader. Dependency graph, distribution tests (5), guide anchors and diff checks pass. CI now exercises GCC/TinyCC dynamic loading on Linux and dynamic compilation/missing-runtime startup on Windows, alongside the existing package consumers.