Repository navigation
Validate isolated release consumers and centralize compatibility pins - #12
Merged
Merged
Conversation
antono3
commented
Oct 11, 2026
antono3
left a comment
Collaborator
Author
There was a problem hiding this comment.
Agent code review of 9ded6c5.
Reviewed asset-directory selection and preservation of explicit file arguments, checksum and archive validation, process timeout/exit checks, isolated consumer environments, manifest resolution and Linux/Windows setup consumers. Local verification passed 19 V test files, shader checks and a rebuilt relocated Windows package. No blocking findings. The existing v0.23.0 download still needs a subsequent release to deliver the source fix.
All applicable CI checks and complete workflows passed for this commit. This records agent review; it is not an independent human approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Launching the Windows release from outside its extracted directory currently fails graphical startup because shaders and audio use working-directory-relative paths. Select assets beside a packaged executable while preserving explicitly supplied user file paths and source-build behavior.
Centralize tested compiler, bootstrap, module, header, native-tool and CI-runtime pins in compatibility.json. Windows/Linux setup and CI consume the manifest; direct VPM declaration disagreement and incorrect installed releases fail validation. Existing recursive dependency checks remain in place.
Add separate Windows and Linux package consumer jobs that download candidate archives, relocate them to paths with spaces, isolate user configuration and development environment, and check bounded simulation, graphical startup and invalid-argument exit behavior. Linux runs in a fresh runtime-only Ubuntu container. A publication/manual workflow verifies downloaded release checksums and runs the same tests.
Validation: distribution regression checks and workflow actionlint pass locally. A rebuilt Windows candidate passes the relocated/unrelated-directory launch test on a physical Vulkan GPU; published v0.23.0 reproduces the graphical launch failure. All eight PR checks and the complete CI workflow passed on commit 9ded6c5, including Windows/Linux candidate-package consumers. Publishing a later release is needed to deliver the fix to download users; existing release assets are unchanged.