Bugfix on folder spaces#10
Open
RikilG wants to merge 1 commit intoantonioolf:masterfrom
RikilG:fix-folder-spaces
Open
Bugfix on folder spaces#10RikilG wants to merge 1 commit intoantonioolf:masterfrom RikilG:fix-folder-spaces
RikilG wants to merge 1 commit intoantonioolf:masterfrom
RikilG:fix-folder-spaces
Conversation
Owner
|
Hello @RikilG , first sorry for the delay in responding. I was very busy with personal issues and was planning to take the time to analyze your contribution calmly. But I decided to answer now not to leave you so long without an answer. And if you have more ideas, feel free to continue contributing, let's make CDI a great tool :) Thank you very much in advance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR can close #2 , #6 . I was able to come up with a simple fix for this. I just changed the Input Field Separator (IFS) variable to make bash break at new-line instead of the default space separator. I figured out this would be the easiest fix as the program (
cdi.sh) is based on splitting at new-lines (w.r.tls). In future, in case you need to revert back to default in some function, you can always useunset IFSto remove the modifications.This is how it was before:

Here's how it looks now:

When you

cdintofolder with spaces, it looks like:You can check the changes in code (it's just one line) in the files changed tab in the PR and let me know if I should make any more changes. Thank You!