fix(macos): preserve streamed sandbox violations - #519
Open
linhongyu510 wants to merge 2 commits into
Open
Conversation
Author
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
readlineso coalesced records, split records, and split UTF-8 code points are handled correctlyThe previous implementation treated each stdout
datachunk as a complete log record and selected only its first violation/tag pair. Because stream chunks are arbitrary, one chunk could contain multiple records or part of one record, causing dropped events, missing attribution, and corrupted Unicode paths.This changes ingestion only; it does not alter Seatbelt profiles or sandbox permissions.
Verification
origin/main: 8 failed, 1 passednpx eslint .npm run typechecknpm run buildA live macOS probe also confirmed that a denied
catexits withOperation not permittedand the NDJSON monitor reports the matchingfile-read-dataevent with the exact command attribution.