Strip IPv6 URI brackets before rustls ServerName parsing#3
Merged
Conversation
rpb-ant
approved these changes
Mar 17, 2026
`Uri::host()` returns IPv6 literals with their URI brackets intact (`[::1]`), but `rustls_pki_types::ServerName::try_from` expects a bare address. Bracketed input is rejected as an invalid DNS name, so TLS connections to IPv6 literals failed outright. Stripping the brackets lets rustls parse it as `ServerName::IpAddress`, same as it already does for IPv4 literals (which have no brackets in URI form). Fixes #1
iainmcgin
force-pushed
the
fix/ipv6-sni-brackets
branch
from
6fc4eff to
6633632
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1.
Uri::host()returns[::1]for IPv6 literals;rustls_pki_types::ServerName::try_fromrejects the bracketed form as an invalid DNS name. Stripping the brackets lets rustls parse it asServerName::IpAddress, same as IPv4 literals (which have no brackets).Two new tests cover IPv4 and IPv6 address inputs.