Open
Conversation
The buf.plugin.yaml manifest and Dockerfile in connectrpc-codegen/ were for publishing protoc-gen-connect-rust to the Buf Schema Registry. The real plugin definitions now live in bufbuild/plugins (PRs #2333, #2334), which has its own build infrastructure. These in-repo copies are vestigial. Both files had drifted: buf.plugin.yaml referenced a nonexistent 'serde' buffa feature (it's 'json') and 0.1 version requirements; Dockerfile used rust:1.84-bookworm which predates edition 2024's 1.85 minimum. None of that matters now - neither file was consumed by anything in CI.
rpb-ant
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes
connectrpc-codegen/buf.plugin.yamlandconnectrpc-codegen/Dockerfile.These were for BSR plugin publishing, but the real definitions are now in bufbuild/plugins (#2333, #2334). Neither file was consumed by CI; both had drifted (wrong buffa feature name, stale versions, outdated Rust base image).
−53 lines, no code changes.