Skip to content

fix(examples/hooks): bash_command_validator regex false negatives (#59441) #59508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dhruba-datta wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −3
Open

fix(examples/hooks): bash_command_validator regex false negatives (#59441) #59508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions examples/hooks/bash_command_validator_example.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,18 @@
import re
import sys

# Define validation rules as a list of (regex pattern, message) tuples
# Define validation rules as a list of (regex pattern, message) tuples.
#
# Each pattern is anchored to the start of the command (^) so it matches
# only when the listed command is the leading binary of the pipeline.
# Downstream uses (e.g. `cat foo | grep bar`) are intentionally not flagged.
_VALIDATION_RULES = [
(
r"^grep\b(?!.*\|)",
r"^grep\b",
"Use 'rg' (ripgrep) instead of 'grep' for better performance and features",
),
(
r"^find\s+\S+\s+-name\b",
r"^find\s+\S+.*\s-name\b",
"Use 'rg --files | rg pattern' or 'rg --files -g pattern' instead of 'find -name' for better performance",
),
]
Expand Down