Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Follow-up to #123 and #207.
🧭 Context
My last PR (#207) cleaned up some dead code, but running
knipagain turned up more: unused functions, constants that nothing imports, a dependency (mlly) that nothing in the inspector package actually uses, and a bunch of types exported for no reason.📚 Description
Three kinds of changes:
Deleted entirely:
mllyfromnode-modules-inspector/package.jsonand its catalog entry inpnpm-workspace.yamlsection()informat-util.ts— defined but never calledMARK_INFOandMARK_ERRORinconstants.ts— nothing references themWS_EVENT_NAMEinshared/constants.ts— sameexportkeyword removed (still used internally, just not imported anywhere else):ParsedSemverinsemver.tsReportTypeinrun-report.tsInspectorDevframeFlagsindevframe.tsFilterSchemainfilters.tsReportConsumerDto,MaintainerActionItemDto,MaintainerActionDepUpgradeDto,MaintainerActionPublintDto,toMaintainerItemDtoindto.tsDepUpgradeAction,PublintAction,MaintainerActionSortMode,MaintainerActionAuthorEntryinmaintainers.tsResolveRegistryDependenciesProgress,RegistryResolveWarningTypeinregistry/types.tsAll verified with grep — nothing outside the defining file imports any of these.