Skip to content

chore: remove unused exports and dependencies - #212

Open
clanzhang wants to merge 1 commit into
antfu:mainfrom
clanzhang:chore/remove-unused-exports
Open

clanzhang wants to merge 1 commit into
antfu:mainfrom
clanzhang:chore/remove-unused-exports

Conversation

@clanzhang

Copy link
Copy Markdown
Contributor

🔗 Linked issue

Follow-up to #123 and #207.

🧭 Context

My last PR (#207) cleaned up some dead code, but running knip again turned up more: unused functions, constants that nothing imports, a dependency (mlly) that nothing in the inspector package actually uses, and a bunch of types exported for no reason.

📚 Description

Three kinds of changes:

Deleted entirely:

  • mlly from node-modules-inspector/package.json and its catalog entry in pnpm-workspace.yaml
  • section() in format-util.ts — defined but never called
  • MARK_INFO and MARK_ERROR in constants.ts — nothing references them
  • WS_EVENT_NAME in shared/constants.ts — same

export keyword removed (still used internally, just not imported anywhere else):

  • ParsedSemver in semver.ts
  • ReportType in run-report.ts
  • InspectorDevframeFlags in devframe.ts
  • FilterSchema in filters.ts
  • ReportConsumerDto, MaintainerActionItemDto, MaintainerActionDepUpgradeDto, MaintainerActionPublintDto, toMaintainerItemDto in dto.ts
  • DepUpgradeAction, PublintAction, MaintainerActionSortMode, MaintainerActionAuthorEntry in maintainers.ts
  • ResolveRegistryDependenciesProgress, RegistryResolveWarningType in registry/types.ts

All verified with grep — nothing outside the defining file imports any of these.

@pkg-pr-new

pkg-pr-new Bot commented Sep 20, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/node-modules-inspector@212
npm i https://pkg.pr.new/node-modules-tools@212

commit: 72eee43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant