fix: correct test fixtures for @octokit/rest and @octokit/core - #206
Merged
Merged
Conversation
Remove incorrect `main` and `module` fields from test fixtures that don't exist in the actual npm packages. Both packages are ESM-only with only `type: "module"` and `exports` fields. Fixes antfu#128
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove incorrect
mainandmodulefields from test fixtures that don't exist in the actual npm packages. Both packages are ESM-only with onlytype: "module"andexportsfields.Fixes #128
🔗 Linked issue
Resolves #128
🧭 Context
The test fixtures for
@octokit/rest@22.0.1and@octokit/core@7.0.5containedmainandmodulefields that do not exist in the real npm packages. These are pure ESM packages that declare their module type solely viatype: "module"and theexportsfield.📚 Description
mainfield from@octokit/core@7.0.5fixture — the real package has nomainmainandmodulefields from@octokit/rest@22.0.1fixture — the real package has neitheranalyzePackageModuleTypecorrectly returns'esm'for both packages using the actual package.json data from npmanalyze-esm.tsdoes not need changes