Optimize SPFresh base-delta HBC maintenance - #214
Open
ajroetker wants to merge 427 commits into
Open
Conversation
# Conflicts: # go/pkg/antfly/src/store/db/indexes/openapi.gen.go # go/pkg/sdk/oapi/client.gen.go # zig/build.zig # zig/pkg/antfly/src/data/runtime.zig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
zig build spfresh-production-test --summary all/private/tmp/antfly-spfresh-hbc-final-gate-evidence.jsonl; the default gate now FAILS only the read recall denominator checks:read_packed_hbc_hbc,read_flat_rabitq, andread_two_level_rabitqreportrecall_total=315, while the current gate requires>=10000skips), so the original cold/warm concern is resolved; rerun read evidence with a >=1000 recall denominator before claiming a full optimized-gate PASS againValidation
zig build lib-db-test --summary all(378/382 passed, 4 skipped)zig build lib-data-runtime-test --summary allzig build spfresh-production-test --summary allbash -n zig/scripts/run_spfresh_hbc_comparison.shpython3 -m py_compile zig/scripts/summarize_spfresh_hbc_comparison.pygit diff --checkpython3 zig/scripts/summarize_spfresh_hbc_comparison.py /private/tmp/antfly-spfresh-hbc-final-gate-evidence.jsonl --optimized-gate check --gate-production-proof-file zig/bench/results/spfresh-production-test.log(expected FAIL on the three stale read recall-denominator checks above)