Get antfly-sdk runnable - #2
Open
dovinmu wants to merge 4 commits into
Open
Conversation
Bug antflydb#1: Fixed imports from non-existent api_table module - Changed imports to use correct paths: data_operations/batch_write, data_operations/lookup_key, and table_management/ for table ops Bug antflydb#2: Fixed cast() misuse with BatchRequestInserts - cast() only hints types, doesn't convert data - Now properly creates BatchRequestInserts and BatchRequestInsertsAdditionalProperty model instances from dicts Bug antflydb#3: Removed query method referencing non-existent endpoints - query_table and global_query don't exist in generated code - QueryRequest and QueryRequestFullTextSearch models don't exist - Removed the query method until proper endpoints are available
Bug #4: Fixed type mismatch with Client/AuthenticatedClient - Created ApiClient type alias to document that both types work - Removed cast() calls and added type: ignore comments - Both Client and AuthenticatedClient have identical interfaces HTTP status: Fixed batch_write to accept both 200 and 201 - Server returns 200 but generated code expected 201 - Now accepts either status code as success
dovinmu
changed the title
Contributor
|
Oh I missed this sorry dude!! Thanks rowan, looks like there's a small merge conflict I can fix if you don't want to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current version of the module won't run successfully, this gets it usable.
Before:
$ uv run --with "antfly-sdk @ git+https://github.com/antflydb/antfly-python.git@main" python -c "import antfly; print('done')"After:
$ uv run --with "antfly-sdk @ git+https://github.com/dovinmu/antfly-python.git@claude/fix-import-bug-NCnWk" python -c "import antfly; print('done')"Bug #1: Fixed imports from non-existent api_table module
data_operations/lookup_key, and table_management/ for table ops
Bug #2: Fixed cast() misuse with BatchRequestInserts
BatchRequestInsertsAdditionalProperty model instances from dicts
Bug #3: Removed query method referencing non-existent endpoints
Bug #4 (Medium): Type mismatch - client.py creates Client but casts to AuthenticatedClient when calling APIs. Works at runtime but is a type safety issue.
Bug #5: observed /batch returning a 200 instead of 201 for single-document inserts