Repository navigation
REFACTOR: Move mcad assembly - #8169
hui-zhou-a wants to merge 35 commits into
Conversation
|
@hui-zhou-a Could you consider checking the extensions repo to perform this refactoring ? Some refactoring was made by @ecoussoux-ansys and this might conflict with some of the existing changes. If there is a need to have this into pyaedt soon, let me know and we can adapt. Otherwise, I would advise to have a look there too :) |
|
@copilot summarize what has been done in this PR |
This PR moves the MCAD assembly data models and core assembly operations into |
There was a problem hiding this comment.
Temporarily mark as "request changes" until my comment isn't answered
All changes in this PR will overwrite the one in extension repo. @eblanco-ansys what do you think? |
I would proceed into merging this into PyAEDT and then create a new PR in the extensions repo to align it. We need this refactoring being part of PyAEDT soon @SMoraisAnsys |
|
@SMoraisAnsys are you ok to approve this PR? |
|
I think we should review the code, because I see some pieces not efficient. |
|
I think the code can be updated to use non native API calls |
|
@hui-zhou-a @eblanco-ansys I did the review of this PR, and I performed some modifications. It is still missed:
|
Description
Issue linked
#8168 #8167
Checklist