Skip to content

[2.7 Backport] | Role Team Assignment Support for other entities - #261

Merged
TheNova22 merged 2 commits into
ansible:stable-2.7from
TheNova22:rta_backport_2_7
Sep 28, 2026
Merged

TheNova22 merged 2 commits into
ansible:stable-2.7from
TheNova22:rta_backport_2_7

Conversation

@TheNova22

Copy link
Copy Markdown
Collaborator

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test update
  • Refactoring (no functional changes)
  • Development environment change
  • Configuration change

…ble#205)

* [ACA-6528] Role Team assignment support EDA assignments with  name

Signed-off-by: Rohit Thakur <rothakur1210@gmail.com>

* fix role team assingments tests, rolde defintion idem

Signed-off-by: Rohit Thakur <rothakur1210@gmail.com>

* fix tests

Signed-off-by: Rohit Thakur <rothakur1210@gmail.com>

* incorporate comments

Signed-off-by: Rohit Thakur <rothakur1210@gmail.com>

* update with imports

Signed-off-by: Rohit Thakur <rothakur1210@gmail.com>

* fix lint issues

Signed-off-by: Rohit Thakur <rothakur1210@gmail.com>

* Update hub endpoints, add relevant integration testcases

* Fix linting error

* Fix integration failures on mock device

* Update examples to include other controller, eda and hub endpoints

* Address coderabbit reviews and fix integration tests

* role_team_assignment: org-scoped lookup and drop unimplemented object_ids

Close the customer multi-org name gap with optional organization on
assignment_objects, fail closed on ambiguous matches, and remove the
2.7-only object_ids docs ghost (never present on stable-2.6).

Co-authored-by: Cursor <cursoragent@cursor.com>

* Fix sanity and ansible-lint for role_team_assignment validation
Address pylint use-maxsplit-arg, ruff import order, and ansible-lint
issues in the manual suite; tighten Hub/EDA assertions.

* Apply ruff format to role_team_assignment action
Also ignore manual validation vars.yml so credentials are not committed.

* Fix tests/manual by replacing failed_when with ignore_errors

* Update controller & eda org variables + docs related to assignment_objects

* ruff fix

* Enforce role_definition.content_type for the type input as to make it consistent with AAP api

* Add additional name checks and integration changes

* Fix integration warnings

* Update type based checks to be triggered when name is involved in the operation

* Update existing RTA to consume the latest base_action changes

---------

Signed-off-by: Rohit Thakur <rothakur1210@gmail.com>
Co-authored-by: Jayant Sogikar <jayantsogikar@gmail.com>
Co-authored-by: Jayant Sogikar <jsogikar@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Bradley A. Thornton <brad@thethorntons.net>
Co-authored-by: Komal Desai <96862647+komaldesai13@users.noreply.github.com>
@TheNova22 TheNova22 added safe to test PR is safe to run integration tests 2.7-backport labels Sep 25, 2026
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: febf5a66-f16d-44b2-a8a1-578133f1bda2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

CasC Notification

This PR touches areas that may affect the CasC collections (e.g. infra.aap_configuration).

Detected changes in CasC-monitored areas:

  • Module changes: plugins/modules/role_team_assignment.py plugins/modules/user.py
  • Action plugin changes: plugins/action/base_action.py plugins/action/role_definition.py plugins/action/role_team_assignment.py plugins/action/user.py
  • plugin_utils changes (may affect return structure or auth): plugins/plugin_utils/ansible_models/role_team_assignment.py plugins/plugin_utils/api/v1/role_team_assignment.py plugins/plugin_utils/manager/platform_manager.py plugins/plugin_utils/platform/direct_client.py plugins/plugin_utils/resource_type_map.py

Please tag the CasC collections team in this PR so they are aware of the change.

This comment is posted automatically and does not block merge.

@github-actions

Copy link
Copy Markdown

CasC Notification

This PR touches areas that may affect the CasC collections (e.g. infra.aap_configuration).

Detected changes in CasC-monitored areas:

  • Module changes: plugins/modules/role_team_assignment.py plugins/modules/user.py
  • Action plugin changes: plugins/action/base_action.py plugins/action/role_definition.py plugins/action/role_team_assignment.py plugins/action/user.py
  • plugin_utils changes (may affect return structure or auth): plugins/plugin_utils/ansible_models/role_team_assignment.py plugins/plugin_utils/api/v1/role_team_assignment.py plugins/plugin_utils/manager/platform_manager.py plugins/plugin_utils/platform/direct_client.py plugins/plugin_utils/resource_type_map.py

Please tag the CasC collections team in this PR so they are aware of the change.

This comment is posted automatically and does not block merge.

@github-actions

Copy link
Copy Markdown

DVCS PR Check Results:

Could not find JIRA key(s) in PR title, branch name, or commit messages

@TheNova22
TheNova22 merged commit ee5dfff into ansible:stable-2.7 Sep 28, 2026
44 of 45 checks passed

This branch was successfully deployed

1 active deployment
CI — d2a062c8 Deployed Sep 25, 2026 by TheNova22 via integration (http-direct) #42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.7-backport safe to test PR is safe to run integration tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants