-
Notifications
You must be signed in to change notification settings - Fork 74
feat: customizable appearance — theme presets + accent colors #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
itsfabioroma
wants to merge
8
commits into
ankitvgupta:main
Choose a base branch
from
itsfabioroma:feat/appearance-customization
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8cdb2be
feat: customizable appearance — theme presets + accent colors
itsfabioroma b918718
feat: add Gmail send-as alias support
itsfabioroma 0626d57
fix: migration crash on fresh DB + guard getSendAsAliases
itsfabioroma 616a2a4
style: fix prettier formatting
itsfabioroma 046732a
fix: validate appearance config at IPC boundary
itsfabioroma 93923da
fix: validate hex input in hexToRgbTriplet
itsfabioroma ed1e04c
remove unrelated send-as alias changes from appearance PR
itsfabioroma 4a2e0dc
fix: dark-mode bg-gray-100 override, color picker IPC flood, accentCo…
itsfabioroma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appearance:setThe handler trusts the renderer-supplied
appearanceobject without parsing it throughAppearanceConfigSchema. Per project guidelines ("validate at boundaries"), an invalid or extra field (e.g. an injected__proto__key or a future incompatible preset string) would be written verbatim to the electron-store. AsafeParseguard makes the boundary explicit:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already fixed in commit 046732a — the handler now uses
AppearanceConfigSchema.safeParse(rawAppearance)and returns an error on invalid config. Seesettings.ipc.ts:683-686.