-
Notifications
You must be signed in to change notification settings - Fork 74
Fix: split label conditions match by name and check all thread emails #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gpechenik
wants to merge
7
commits into
ankitvgupta:main
Choose a base branch
from
gpechenik:fix/split-label-matching
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b9797da
Fix split label conditions: match by name and check all thread emails
gpechenik 47c6863
Address review feedback: account ID, mixed conditions, multi-account
gpechenik a20eec5
Prefer account-specific labels in name→ID resolution
gpechenik b2a314d
Add reactivity for label map updates via store version counter
gpechenik 15893bb
Clean up review findings: remove unused destructure, log label fetch …
gpechenik 269fd19
Fix negated label conditions using .some() instead of .every()
gpechenik 03774c7
Fix: add incrementLabelMapVersion to App component's useAppStore dest…
gpechenik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| import { ipcMain } from "electron"; | ||
| import { getClient } from "./gmail.ipc"; | ||
| import type { IpcResponse } from "../../shared/types"; | ||
|
|
||
| interface LabelInfo { | ||
| id: string; | ||
| name: string; | ||
| type: string; | ||
| color?: { textColor: string; backgroundColor: string }; | ||
| } | ||
|
|
||
| export function registerLabelsIpc(): void { | ||
| // List all labels for an account | ||
| ipcMain.handle( | ||
| "labels:list", | ||
| async (_, { accountId }: { accountId: string }): Promise<IpcResponse<LabelInfo[]>> => { | ||
| try { | ||
| const client = await getClient(accountId); | ||
| const labels = await client.listLabels(); | ||
| return { success: true, data: labels }; | ||
| } catch (error) { | ||
| console.error("[Labels] Failed to list labels:", error); | ||
| return { success: false, error: String(error) }; | ||
| } | ||
| } | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
devin-ai-integration[bot] marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.