Add shared Codex and Claude agent setup#136
Open
ankitvgupta wants to merge 10 commits into
Open
Conversation
Greptile SummaryThis PR reorganises agent guidance into a shared
Confidence Score: 5/5Safe to merge — all changes are documentation, tooling config, and script fixes with no runtime application code modified. The diff is documentation, agent guidance, and dev-tooling scripts. The only behavioural change in executable code is a genuine bug fix (hardcoded CDP port in prompt templates) and a consistent port number update in mcp.json. No application source files are touched. No files require special attention.
|
| Filename | Overview |
|---|---|
| AGENTS.md | New canonical agent guidance file — comprehensive and well-structured, covering workflow, coding standards, git conventions, and shared skills. |
| CLAUDE.md | Reduced to a thin adapter pointing at AGENTS.md, with only Claude-specific notes retained. |
| scripts/agentic-verify.mjs | Added .codex/, skills/, and AGENTS.md to demo-safe patterns; passes CDP_URL to both prompt templates fixing the hardcoded-9222 bug. Minor: the explicit /^AGENTS.md$/ entry is redundant since /.md$/ already covers it. |
| scripts/agentic-verify-prompts/feature-brief.md | Replaced hardcoded http://127.0.0.1:9222 with {{CDP_URL}} template variable — fixes agent mismatch when Electron lands on a dynamic port. |
| scripts/agentic-verify-prompts/exploration-rubric.md | Same hardcoded-port fix as feature-brief.md. |
| .claude/mcp.json | CDP port changed from 9222 to 9223, consistent with electron-devtools-testing skill documentation explaining the port choice. |
| skills/reviewloop/SKILL.md | Added a Codex compatibility note clarifying that allowed-tools is Claude-specific frontmatter; Codex agents must follow command scope manually. |
| skills/electron-devtools-testing/SKILL.md | Moved from .claude/skills/ to shared skills/; content updated to reference port 9223 and explain the rationale. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["AGENTS.md\n(canonical guidance)"] --> B["CLAUDE.md\n(thin adapter)"]
A --> C["Codex reads AGENTS.md directly"]
subgraph skills ["Shared skills/"]
S1[clear-caches]
S2[electron-devtools-testing]
S3[gh-local]
S4[github-cli]
S5[reviewloop]
S6[take-screenshots]
end
skills --> CL[".claude/skills/ symlinks"]
skills --> CO[".codex/skills/ symlinks"]
CL --> B
CO --> C
subgraph agentic ["agentic-verify.mjs"]
AV1["findFreePort(9223)"]
AV2["CDP_URL = http://127.0.0.1:PORT"]
AV3["launchElectron(dataMode)"]
AV4["fillTemplate(feature-brief.md, {CDP_URL,...})"]
AV5["fillTemplate(exploration-rubric.md, {CDP_URL,...})"]
AV1 --> AV2 --> AV3
AV2 --> AV4
AV2 --> AV5
end
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A["AGENTS.md\n(canonical guidance)"] --> B["CLAUDE.md\n(thin adapter)"]
A --> C["Codex reads AGENTS.md directly"]
subgraph skills ["Shared skills/"]
S1[clear-caches]
S2[electron-devtools-testing]
S3[gh-local]
S4[github-cli]
S5[reviewloop]
S6[take-screenshots]
end
skills --> CL[".claude/skills/ symlinks"]
skills --> CO[".codex/skills/ symlinks"]
CL --> B
CO --> C
subgraph agentic ["agentic-verify.mjs"]
AV1["findFreePort(9223)"]
AV2["CDP_URL = http://127.0.0.1:PORT"]
AV3["launchElectron(dataMode)"]
AV4["fillTemplate(feature-brief.md, {CDP_URL,...})"]
AV5["fillTemplate(exploration-rubric.md, {CDP_URL,...})"]
AV1 --> AV2 --> AV3
AV2 --> AV4
AV2 --> AV5
end
Reviews (8): Last reviewed commit: "Allow lockfile-only pre-pr soft pass" | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Owner
Author
|
Reviewloop complete on Fixed all Greptile feedback:
No review issues intentionally left open. Full |
Owner
Author
|
Final reviewloop status on
No review issues are left open. |
Owner
Author
✅ Pre-PR verification — PASS
Agentic verification — summaryAgentic verification — verify-diff
Summarycategory=F. This PR is a pure developer-tooling and documentation reorganization: it moves skill files from .claude/skills/review-code/ into a shared skills/ directory with symlinks, updates the MCP chrome-devtools port from 9222 to 9223, updates scripts/agentic-verify.mjs and scripts/pre-pr.mjs developer workflow scripts, and refreshes AGENTS.md/CLAUDE.md documentation. No source files under src/ were modified — there is no user-facing app behavior to exercise. The app loads correctly in demo mode (inbox renders with fixture emails confirming no regression), but there is no diff-affected code path in the application to drive end-to-end. A real-mode environment would not change this verdict since the changes are exclusively to developer tooling and documentation. Agentic verification — literal traceThis comment is upserted by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Pre-PR verdict: PASS
fullc9105de