Fix for iframe css injection #736
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this fix the issue ever since Chrome 108 of user styles not loading upon initial page load? The workaround is to reload the page for the styles to be applied. Hoping this patch obviates the need for the workaround. |
Contributor
Author
@589290 not sure, I am not able to replicate the issue you're describing on Chrome 108, is there an existing issue? |
|
is this still an issue? |
|
I'm still experiencing this issue. Chrome Version 116.0.5845.188 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that CSS was no longer being injected successfully into iframes. I am not sure why it stopped working (seems to have worked at some point in the past), but this solution does away with the old system for handling iframes (though that deprecated code could still be cleaned up), and simply iterates through all iframes found on the page and injects a
<style>element for each one.