Repository navigation
RFC-005: Agent Framework's push lane now binds a reference to its server - #25
Merged
nissa-seru merged 1 commit intoOct 18, 2026
Merged
Conversation
Since Agent Framework 7b21471 (agent-framework#510), the push lane registers a reference with the server that sent the event, as the tool-result lane does, so fetch_reference no longer refuses such a reference as unbound. RFC-005's description of the supplied adapter said the push lane registers it with no server, so that such a reference can't be fetched in the Framework, and the adapter's comment said the same. RFC-005 now says the Framework binds a reference at receipt from a tool result or a push event, and that from the measured baseline, 02adf27, until 7b21471, the push lane left it unbound, so at those revisions the fetch rows exercise the fetcher only because the adapter binds the reference first. The adapter's comment says the same, and names where the push lane registers it: PushHandler passes the event's server through convertBlock to buildReferenceStub. The adapter still binds each reference before rendering, so its results don't depend on whether the revision under test binds in the push lane. Checked with RFC-005's recipe on Linux, Bun 1.4.3, against Agent Framework 02adf27 (the measured baseline), 6dfea06 (main just before 7b21471), 7b21471 and 61a6997: - With the adapter as committed, 02adf27 gives 45/45 schema and 43/45 Host expectations, as RFC-005 says, and the other three give 45/45 and 45/45. The isolation test passes at each. - With the adapter changed to register each reference unbound, so that the push lane's own registration decides, 02adf27 and 6dfea06 fail the same 12 fetch cases, those that expect a request. At 6dfea06, 8 fail on the fetcher's refusal of an unbound reference and 4 on their request count, with no request made. 02adf27 gives the same, except that 18-label-controls fails first on its known label check. 7b21471 and 61a6997 pass all 45. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Required label not found on this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC-005's conformance section said Agent Framework's push lane registers a reference with no server, so a reference that only a push event delivered can't be fetched in the Framework. anima-research/agent-framework#510 changed that. Since Agent Framework
7b21471, the push lane registers a reference with the server that sent the event, as the tool-result lane already did. This PR updates the two places that described the old behaviour. It changes no vector, no check and no adapter code.Changes
02adf27, until7b21471, the push lane left a reference unbound, so at those revisions the fetch rows exercise the fetcher only because the adapter binds the reference first.conformance/agent-framework-bulk-references.mjssays the same, and names where the push lane registers a reference:PushHandlerpasses the event's server throughconvertBlocktobuildReferenceStub. The adapter still binds each reference to the fixture's server before rendering, so its results don't depend on whether the revision under test binds in the push lane.Tests
RFC-005's recipe, on Linux with Bun 1.4.3, against Agent Framework
02adf27,6dfea06(main just before7b21471),7b21471and61a6997:02adf27gives 45/45 schema and 43/45 Host expectations, as RFC-005 says, and the other three give 45/45 and 45/45. The runner, fixture and isolation tests pass.02adf27and6dfea06fail the same 12 fetch cases, those that expect a request. At6dfea06, 8 fail on the fetcher's refusal of an unbound reference and 4 on their request count, with no request made.02adf27gives the same, except that18-label-controlsfails first on its known label check.7b21471and61a6997pass all 45.— Petra-1012 (Opus), contributing through nissa-seru
— Description checked and posted by Daniel-2612 (Opus)