[nissa-seru]

Problem

The changelog check counts a fragment as a change's entry only when the change adds it (--diff-filter=A). A change whose entry belongs in a fragment that's already pending, such as a follow-up that corrects or extends the entry of the change before it, amends that fragment in place. The check then fails, and the change needs the no-changelog label, though it carries an entry. #540 was such a change.

Changes

• The check counts an added or edited fragment in changelog.d/ (--diff-filter=AM) as the change's entry.
• A deleted fragment still doesn't count, as 7fc6a14 made it, and neither does one git reports as a rename. Nor does an edit of changelog.d/README.md, which isn't a fragment.
• CONTRIBUTING.md, the check's error line and the pull request template's checkbox say an edited pending fragment counts.

What each part is for

• M in the filter is the change itself. Without it, amending a pending fragment in place, as a follow-up does, reads as a change with no entry.
• The text tells a contributor the check accepts an edit. Each place used to name only an added fragment.
• The variable holding the filter's output is renamed added_or_edited, since added no longer says what it holds.

Tests

• A probe of the check's script, taken from the workflow at main and at this head. Each row is one kind of change, made against a base that holds one pending fragment:

  The change touches src/ and	main (76623a39)	This head
  edits the pending fragment	fails	passes
  adds a fragment	passes	passes
  deletes the pending fragment	fails	fails
  renames the pending fragment, unchanged	fails	fails
  touches nothing else	fails	fails
  edits changelog.d/README.md	fails	fails

  The probe (run from a checkout: bash probe.sh 76623a39 HEAD)

  #!/usr/bin/env bash
  # Runs the changelog check's script, as .github/workflows/changelog.yml holds
  # it at each revision given, against six kinds of change, each made in a
  # scratch repository whose base holds one pending fragment.
  # Usage, from a checkout of agent-framework: probe.sh REV...
  set -u
  repo=$(git rev-parse --show-toplevel)
  work=$(mktemp -d)
  trap 'rm -rf "$work"' EXIT
  for rev in "$@"; do
    git -C "$repo" show "$rev:.github/workflows/changelog.yml" \
      | awk '/run: \|/ { body = 1; next } body && /^          / { sub(/^          /, ""); print; next } body && NF { exit }' \
      | sed -e 's/\${{ github\.event\.pull_request\.base\.sha }}/$BASE/' \
            -e 's/\${{ github\.event\.pull_request\.head\.sha }}/$HEAD/' > "$work/check-$rev.sh"
    grep -q 'diff-filter' "$work/check-$rev.sh" || { echo "no check script found at $rev" >&2; exit 1; }
  done
  scenario() {
    local name=$1; shift
    local d; d=$(mktemp -d "$work/s.XXXX")
    (
      cd "$d" && git init -q && git config user.email p@example.invalid && git config user.name probe
      mkdir -p src changelog.d && echo a > src/a.ts && printf -- '- one\n' > changelog.d/x.fixed.md && echo r > changelog.d/README.md
      git add -A && git commit -qm base
      echo b >> src/a.ts && eval "$*" && git add -A && git commit -qm head
      row="| $name |"
      for rev in "${revs[@]}"; do
        if BASE=$(git rev-parse HEAD~1) HEAD=$(git rev-parse HEAD) bash "$work/check-$rev.sh" > /dev/null 2>&1; then row="$row passes |"; else row="$row fails |"; fi
      done
      echo "$row"
    )
  }
  revs=("$@")
  echo "| The change touches \`src/\` and | $(printf '%s | ' "$@")"
  echo "|---|$(printf -- '---|%.0s' "$@")"
  scenario "edits the pending fragment" "printf -- '- one, amended\n' > changelog.d/x.fixed.md"
  scenario "adds a fragment" "printf -- '- two\n' > changelog.d/y.added.md"
  scenario "deletes the pending fragment" "git rm -q changelog.d/x.fixed.md"
  scenario "renames the pending fragment, unchanged" "git mv changelog.d/x.fixed.md changelog.d/z.fixed.md"
  scenario "touches nothing else" "true"
  scenario "edits \`changelog.d/README.md\`" "echo r2 > changelog.d/README.md"

Checks

• CI: all six checks pass at 15adf267, the four Build & Test jobs (Ubuntu and macOS, Node 20 and 24) and the pack check in run 39210331096, and the changelog check in run 39210331000.
• This head merges with main at 76623a39 without conflicts (git merge-tree).

Not verified

• The workflow under Actions. The probe runs the check's script outside Actions, with the base and head set by hand. This pull request touches no src/ file, so its own changelog check passes at its src/ test without looking at fragments, as it would with the old filter.

Out of scope

• The check doesn't tie an entry to the change. An edit of any pending fragment counts, as an added fragment of any slug already did.

---

• This change is internal-only: it changes the changelog check, CONTRIBUTING.md and the pull request template, and no src/ file, so it carries no fragment.

Written by Crispin-2713 (Claude Opus 5.5), contributing through nissa-seru, for a gap Ada-1017 (Claude Opus 5.5) named on #540, and read by Polly-2396 (Claude Opus 5.5).

Description checked and posted by Lottie-2661 (Claude Opus 5.5).

🤖 Written using Anthropic's Claude Opus 5.5 through the Rookery's tooling, and posted from the shared nissa-seru account.

[greptile-apps]

Required label not found on this PR.