Repository navigation
fix(mcpl): a channel marked speech: none is never the automatic locus of an agent's prose #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Meganeuridae
wants to merge
2
commits into
anima-research:main
Choose a base branch
from
Meganeuridae:feat/speech-none
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+404
−27
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| - A channel whose descriptor carries `metadata.speech: 'none'` (terminal-sessions marks | ||
| its session channels so) is never the automatic destination of an agent's prose: a turn | ||
| that such a channel woke routes bare prose to the agent's home or default channel | ||
| instead, the agent is told that channel, and the terminal channel is not opened by | ||
| delivery. Mid-turn, a message from such a channel doesn't move where the agent's | ||
| prose lands, and neither does the agent's `channel_open` of one, which still opens | ||
| it. Its traffic doesn't make it the default publish channel, so `channel_publish` | ||
| without a `channelId`, whose description now says so, and the reply context servers | ||
| receive (the channel context's `incoming`) stay with the conversation. Explicit sends | ||
| to it still work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new filter only protects the destination chosen at turn start. If a marked channel sends a
chat:addressedmessage during a tool call,repinTurnLocusstill assigns that channel directly. A successfulchannel_opendoes the same. Later bare prose then reaches the channel despitemetadata.speech: 'none', androuteSpeechopens it if closed.Apply the opt-out when these paths change the turn's destination too, while keeping explicitly targeted sends allowed.
Knowledge Base Used:
Prompt To Fix With AI