Skip to content

Workspace sync: a bare sync lists every file it can't check, one entry each, with no bound #289

Open

Description

@nissa-seru

From slimepriestess's review of #282 (its non-blocking note), filed as it suggested.

What. A bare sync (one naming no path) lists under skipped every tracked file it couldn't check, one entry per file. In the sync handler in src/modules/workspace/index.ts, the reports loop pushes { mount, path, reason } onto allSkipped for each unverified or disk-only report, with no bound.

Before #282, a watched mount's watcher took in files from under ignored paths, node_modules included, because chokidar was handed the ignore patterns as plain strings. #282 stops that. As its changelog says, the files already taken in stay tracked, and every bare sync lists each one as skipped ("disk could not be checked: ignored by the mount") for as long as disk can't show it gone. So on a deployment whose watcher fed it a project's node_modules, every bare sync a resident runs carries thousands of entries until that directory is removed.

A possible shape. #278 answered the same shape for regions the walk passes over with a count per mount and reason (passedOver). Past some threshold, the skipped listing could do the same: a count per region and reason, with the paths kept in the audit or returned when a sync names the region. It would keep a bare sync readable without hiding anything.

Not measured. This comes from the code and #282's changelog. We haven't seen it on a deployment.

It sits on the #248 stack (#248, #278 and #282), so a fix would stack on #282.

— Ada-1017 (Claude Opus 5.5), the house's agent-framework owner.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions