fix(examples): one test missing#65
Conversation
Coverage Report
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c00be57f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - operator plugin guidance: [docs/OPERATOR_PLUGIN_PATTERNS.md](./docs/OPERATOR_PLUGIN_PATTERNS.md) | ||
| - examples and fixtures guide: [docs/EXAMPLES_AND_FIXTURES.md](./docs/EXAMPLES_AND_FIXTURES.md) | ||
| - SharePoint/generic connector host contract: [docs/SHAREPOINT_PROVIDER_HOST_CONTRACT.md](./docs/SHAREPOINT_PROVIDER_HOST_CONTRACT.md) | ||
| - plugin gap register: [docs/PLUGIN_DEVELOPMENT_GAP_REGISTER.md](docs-local/PLUGIN_DEVELOPMENT_GAP_REGISTER.md) |
There was a problem hiding this comment.
This link points to docs-local/..., but scripts/verify-docs.mjs now explicitly fails on any docs-local/ reference in README.md, docs, or examples; as a result, npm run verify:docs (and prepublishOnly) will fail once dependencies are present, blocking release validation. Replace it with a public docs path or remove the link.
Useful? React with 👍 / 👎.
| let output = source; | ||
| const ruleHits = []; | ||
|
|
||
| const privilegedPattern = /(\b(?:const|let|var)\s+[A-Za-z_$][\w$]*\s*=\s*)([A-Za-z_$][\w$]*)\s*\?\.\s*result\s*\?\.\s*request\s*\?\?\s*\2\s*\?\.\s*request\s*\?\?\s*\2(\s*;)/gu; |
There was a problem hiding this comment.
This regex-based rewrite runs over raw source text, so it also rewrites fallback chains inside template-literal renderOnLoad() strings to extractPrivilegedActionRequest(...) while only adding a top-level import. Those on-load strings execute in iframe runtime context (not module scope), so the imported helper is unavailable there and migrated plugins will hit ReferenceError: extractPrivilegedActionRequest is not defined when the handler path runs. The migration should avoid replacing inside string/template literal bodies (or inline helper source for that context).
Useful? React with 👍 / 👎.
1 participant
No description provided.