Expanded DSData and Utils classes and added CRIOCommunication with serialization - #14
Open
LoadingPleaseWait wants to merge 1 commit into
Open
Expanded DSData and Utils classes and added CRIOCommunication with serialization#14LoadingPleaseWait wants to merge 1 commit into
LoadingPleaseWait wants to merge 1 commit into
Conversation
Owner
|
Yeah, I think actually I remember the bits being reversed for digital inputs and possibly for some other things too. Guess I never got around to implementing that. Thanks, I'll take a look at the commit soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I put the
CRIOCommunicationclass in thecrio2009package. The class is not yet complete but it can serializeDSData. The way it does the serialization should be the same as the way it is done in theprotooldpackage. The digital inputs' byte could be reversed as a wiki documenting the cRIO protocol specifies the reverse of what is done inprotoold.