Draft
Conversation
aneojgurhem
requested changes
Apr 4, 2025
Contributor
aneojgurhem
left a comment
There was a problem hiding this comment.
I think you should write some documentation to explain what does your application
aneojgurhem
reviewed
Apr 7, 2025
aneojgurhem
reviewed
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adding my version of client/worker in order to be reviewed and upgraded.
Description
This test is my first attempt of using parallelization in ArmoniK. Tasks are creating parts of a larger python list that is constructed by aggregating those small parts.
Testing
Tested some cases where it should brake, modified the code to resolve it. But I plan to make my computation more reliable by using dictionaries instead of string or list.
Impact
None.
Additional Information
Beside some the mistakes I did, please also specify areas in the code that needs clarifications or modifications concerning code formatting.
Checklist