Replace Sparkle standard driver with custom inline update UI - #35
Merged
Conversation
…date UI Sparkle's built-in alert windows don't work well for this LSUIElement app — they appear unfocused, behind other windows, or on the wrong Space. This replaces the standard driver with a custom SPUUserDriver (UpdateDriver) that folds every Sparkle callback into an observable UpdateState enum, rendered inline as a menu-bar banner with full pipeline visibility (checking → available → downloading → preparing → installing). Adds a debug-only UpdateSimulator for exercising the UI without signing/appcast, and a local E2E test script (just test-update) for the real Sparkle flow. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SPUStandardUpdaterControllerwith a customSPUUserDriver(UpdateDriver) that maps every Sparkle callback into an observableUpdateStateenum, eliminating the focus/activation bugs inherent to alert windows in an LSUIElement appUpdateBannerrendered inline in the menu popover (checking → available → downloading → preparing → installing → error/not-found), replacing the old two-state bannerUpdateSimulator(debug-only) for exercising all banner states without signing or an appcast, andjust test-updatefor local E2E testing with the real Sparkle updater against a localhost appcastScripts/sign-dev-app.shwith auto-detection of Developer ID identityTest plan
just dev— app launches, popover renders normally, no update banner when idlejust test-update— walk through the full update flow: Check Now → available → Install → download → prepare → install → relaunch as bumped versiondefaults write com.miniwhisper.dev UpdateSimulatorScenario happy+just dev— simulator banner walks through all stateshappy,background,notfound,errorjust test— unit tests pass🤖 Generated with Claude Code