[DEBUG PR] Added debug logs to check why the spy doesn't work#2
Draft
andsel wants to merge 10 commits intofeature/string_setting_to_javafrom
Draft
[DEBUG PR] Added debug logs to check why the spy doesn't work#2andsel wants to merge 10 commits intofeature/string_setting_to_javafrom
andsel wants to merge 10 commits intofeature/string_setting_to_javafrom
Conversation
… log4j real logger properly configured to spy the logged messages
…stead of Ruby one
…ingWithDeprecatedAlias spec test.
…when it closes the logger context
91e2048 to
180d597
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run with
SPEC_OPTS="-fd -P logstash-core/spec/logstash/settings/setting_with_deprecated_alias_spec.rb" ./gradlew --rerun-tasks :logstash-core:rubyTestsIt produces a console output like:
Problem statement
While in the setup section of the test the ListAppender (in state
STARTED) works, grabbing the artificial log line, it doesn't catch any log that is created in theDeprecatedAlias,