Skip to content

fix: keep protobuf fields in release builds - #349

Open
arpitagarwal1301 wants to merge 1 commit into
android:mainfrom
arpitagarwal1301:fix/341-keep-protobuf-release-fields
Open

fix: keep protobuf fields in release builds#349
arpitagarwal1301 wants to merge 1 commit into
android:mainfrom
arpitagarwal1301:fix/341-keep-protobuf-release-fields

Conversation

@arpitagarwal1301

Copy link
Copy Markdown

Fixes #341

Summary

  • preserve protobuf-lite generated fields needed by reflective schema parsing in minified release builds
  • keep classes and methods eligible for R8 shrinking and obfuscation

Validation

  • forced :app:minifyReleaseWithR8 :app:assembleRelease passed
  • R8 mapping and final Dex retain bitField0_ and exerciseInfo_ while the message class remains obfuscated
  • :app:testDebugUnitTest passed (48 tests, 14 skipped)
  • git diff --check passed

Limitations

  • Wear OS runtime validation was not available locally; only phone Android virtual devices are installed
  • existing unrelated Spotless and lint errors remain

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ProGuard configuration file proguard-rules.pro by adding a rule to keep class members for any class extending com.google.protobuf.GeneratedMessageLite. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release build of ExerciseSampleCompose crashes

1 participant