fix: handle exercise configuration changes - #348
Open
arpitagarwal1301 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the AndroidManifest.xml file in the ExerciseSampleCompose application to add the configChanges attribute (handling screenSize, smallestScreenSize, orientation, and screenLayout) to MainActivity. This prevents the activity from being restarted during these configuration changes. There are no review comments, and we have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Declare the size and orientation configuration changes handled by
ExerciseSampleCompose'sMainActivity.Why
MainActivityhosts a Compose UI, which can recompose for size-based configuration changes without recreating the activity. Avoiding recreation helps retain the ongoing exercise UI and activity-scoped state through those changes.How
Add the size-specific configuration set from the current Android guidance:
Fixes #329
Validation
git diff --check:app:processDebugMainManifest:app:testDebugUnitTest:app:verifyRoborazziDebug:app:assembleDebugaapt2confirmed config mask0x0d80The local repository's Spotless and lint checks currently fail on pre-existing Kotlin/test formatting and indentation findings outside this XML-only change. A Wear runtime check was not available because no Wear system image or AVD is installed locally.
AI disclosure
This focused manifest correction was prepared and independently reviewed with AI assistance.