feat(reviewer): support configuring a dedicated lightweight reviewer model (#615) - #633
Open
cagdasyurekli wants to merge 1 commit into
Open
feat(reviewer): support configuring a dedicated lightweight reviewer model (#615)#633cagdasyurekli wants to merge 1 commit into
cagdasyurekli wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #615
Summary
This PR allows users to configure an optional, dedicated reviewer model for auto-approve mode instead of always inheriting the session's primary model:
reviewer_model: Optional[str] = NonetoConfigincoworker/config.py.config.tomlusing either[reviewer] model = "..."orreviewer_model = "...".reviewer_modelas a user-global field so workspace configurations cannot override or tamper with the reviewer model.reviewer_modelargument tobuild_engineincoworker/agent.pyand passes it toReviewer.reviewer_modelthroughSessionManagerand exposes REST endpointPOST /v1/settings/reviewer-modeland GET/v1/settings.session.model(preserving 100% backward compatibility).tests/test_config.pyandtests/test_auto_approve_settings.py.Verification
pytest tests/test_auto_approve_settings.py tests/test_config.py tests/test_auto_approve.py tests/test_shadow_eval.py(116/116 passed).