Set modified

[reillysiemens]

Forgive me if I've missed something rather major, but I think this will resolve #54 if I've done it correctly. I went ahead and did File::set_times as well because it seemed related, but didn't make set_modified a pass through to set_times like std::fs because I think this way the error message is improved.

I didn't add the corresponding methods for tokio because they don't (yet) exist in tokio itself. This was mentioned in tokio-rs/tokio#6368, but they're still waiting for a shift in MSRV before adding those methods. They're up to 1.71, but these methods weren't added until 1.75.

If MSRV is an issue for this crate it'd be a bummer, but totally understandable.

[andrewhickman]

This crate uses autocfg to allow wrapping new methods without bumping the MSRV. Please could you gate the new methods so they only appear in Rust 1.75+?

[reillysiemens]

Ah. I see that now. I wasn't familiar with autocfg before this. It's late here, but I'll happily fix that up tomorrow. Thanks for having a look.

[reillysiemens]

@andrewhickman, I believe I've handled gating these methods to Rust 1.75 with autocfg correctly now. I didn't use #[cfg(rustc_1_75)] on the ErrorKind enum because I saw that other gated methods like lock and unlock don't have their respective ErrorKind::Lock and ErrorKind::Unlock variants gated.

Let me know if there's anything else I should do here.

[andrewhickman]

Thanks!

[reillysiemens]

That latest failure is on me (and only slightly embarrassing). Looks like I forgot to apply autocfg to the imports?

[reillysiemens]

Yeah, I believe that was the issue. I tested locally that this compiles now with

rustup toolchain install 1.40
cargo +1.40 check

and saw only unused variant lints for ErrorKind::SetTimes, ErrorKind::SetModified, ErrorKind::Lock, and ErrorKind::Unlock, which is expected with the current implementation.

I'm reasonably confident the CI should pass now. Please have another look when you're able and sorry for the trouble, @andrewhickman. Also, Happy Holidays! 🎄

[andrewhickman]

I've released version 3.2.2 with this change. Thanks again and happy holidays!