fs-err: Use AsRef<Path> to match std::fs#76
Open
thughes wants to merge 1 commit intoandrewhickman:mainfrom
Open
fs-err: Use AsRef<Path> to match std::fs#76thughes wants to merge 1 commit intoandrewhickman:mainfrom
thughes wants to merge 1 commit intoandrewhickman:mainfrom
Conversation
In order for fs-err to be a drop-in replacement for std::fs, it needs to match the std::fs signature exactly. Note that this can result in an extra allocation when the path provided is already a PathBuf, but keeping the same API as std::fs is better than over-optimizing for that case. Fixes andrewhickman#34.
|
I was intending to submit a similar PR but fortunately saw this in time. First of all, my disposition towards this change is positive. I think it brings this library closer to advertised. However I do think this is technically a breaking change, because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order for fs-err to be a drop-in replacement for std::fs, it needs to match the std::fs signature exactly.
Note that this can result in an extra allocation when the path provided is already a PathBuf, but keeping the same API as std::fs is better than over-optimizing for that case.
Fixes #34.