Skip to content

Handle nil return from parse_native/parse in satisfies? #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrew merged 4 commits into from
Mar 19, 2026
Merged

Handle nil return from parse_native/parse in satisfies? #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
91f450d
Handle nil return from parse_native/parse in satisfies?
andrew Mar 19, 2026
ebc76b4
Fix test to use Minitest::Mock instead of stub on module
andrew Mar 19, 2026
03d7f13
Require minitest/mock in test helper
andrew Mar 19, 2026
06427b4
Use plain object stub instead of Minitest::Mock
andrew Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/vers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def self.satisfies?(version, constraint, scheme = nil)
else
parse(sub_range)
end
range.contains?(version)
range&.contains?(version) || false
end
end

Expand Down
11 changes: 11 additions & 0 deletions test/test_vers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,17 @@ def test_empty_range
assert range.empty?
end

def test_satisfies_returns_false_when_parse_native_returns_nil
nil_parser = Object.new
nil_parser.define_singleton_method(:parse_native) { |*, **| nil }

original_parser = Vers.class_variable_get(:@@parser)
Vers.class_variable_set(:@@parser, nil_parser)
refute Vers.satisfies?("1.0.0", "< 2.0.0", "npm")
ensure
Vers.class_variable_set(:@@parser, original_parser)
end

def test_to_vers_string
range = Vers.parse("vers:npm/>=1.2.3|<2.0.0")
vers_string = Vers.to_vers_string(range, "npm")
Expand Down
Loading