docs: scope follow-up overlay tooling gaps - #60
Open
andresdefi wants to merge 1 commit into
Open
Conversation
…s, icon discovery) Snapshot of friction points hit while building decorative line + icon overlays for a marketing screenshot. Four real gaps with file:line citations, acceptance criteria, and S/M/L estimates: - Line shape size floor: preprocess silently rewrites size<50 (M) - No line thickness control: height hard-coded to 4px in two paths (S) - No `list_icons` MCP tool, so agents guess `iconRef` values (S) - `add_overlay` description undersells the already-exposed rotation (S) Picks up after PR #59 which fixed the icon-render and tool-description gaps end-to-end. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Proposal doc — no code changes. Captures four real overlay-tooling gaps hit while building decorative line + icon overlays for a marketing screenshot, with file:line citations, acceptance criteria, and S/M/L estimates so the work is unblocked when someone picks it up:
overlaySchema.sizepreprocess atpackages/core/src/config/schema.ts:290silently rewrites any value under 50 to ≥50 (legacy 1-50% migration), so 10-40 px speed lines aren't reachable.4pxinpackages/core/src/templates/injectors.ts:175(server export) andpackages/web-preview/src/client/hooks/useInstantPatch.ts(live canvas). NoshapeStrokeWidthfield.list_iconsMCP tool, so agents guessiconRefvalues instead of discovering them. Phase 1 =list_icons(S). Phase 2 = additional libraries (M per library, deferred).rotationdescription polish — the field is already inOVERLAY_FIELD_SCHEMAatpackages/mcp/src/tools/overlay.ts:74but buried in the tool description.Gap 3 and Gap 6 from the original investigation prompt were already resolved by PR #59 (
add_overlayicon bake + tool description fix). Numbering preserved for cross-reference; resolved gaps are not re-described.Test plan
main(none of them are in files that change frequently, but worth a sanity check).🤖 Generated with Claude Code