Skip to content

feat(chat): show passive-context wrappers as a labelled nested card - #97

Open
andrebrait wants to merge 2 commits into
mainfrom
feat/passive-context-wrapper-card
Open

feat(chat): show passive-context wrappers as a labelled nested card#97
andrebrait wants to merge 2 commits into
mainfrom
feat/passive-context-wrapper-card

Conversation

@andrebrait

@andrebrait andrebrait commented Oct 11, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Owner

Review companion for kahme247#248: same head branch, base pinned to the same upstream/main commit (7a3f76c), so the diff is identical. Bot reviews only; merge happens upstream.

Summary by CodeRabbit

  • Bug Fixes
    • Tool context labels now show wrapper names and nonempty attributes, making the context easier to identify.
    • Expanded wrapped context appears in a titled, nested card. Plain context remains unchanged.

@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 21 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 212b7d66-01f2-4841-a286-81a938c52f17
📥 Commits

Reviewing files that changed from the base of the PR and between 8ae429a and 767fe20.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • app/globals.css
  • components/MessageView.test.mjs
  • components/MessageView.tsx

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ec6bd126-cd8f-47bb-8f76-f05c6a786284
📥 Commits

Reviewing files that changed from the base of the PR and between 61ea9d7 and 8ae429a.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • app/globals.css
  • components/MessageView.test.mjs
  • components/MessageView.tsx

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough
📝 Walkthrough

Walkthrough

Passive tool context labels now show wrapper tags and nonempty attributes. Expanded wrapped context appears in a nested card. Unwrapped context retains its plain-text presentation.

Changes

Passive Tool Context

Layer / File(s) Summary
Parse wrappers and format labels
components/MessageView.tsx		 Tool results pass parsed wrappers to context formatting. Labels include the wrapper tag and nonempty key=value attributes. Developer-message titles use the same format.
Render and validate wrapped context
components/MessageView.tsx, app/globals.css, components/MessageView.test.mjs, CHANGELOG.md		 Expanded wrapped context renders in a nested card. Tests check labels, empty attributes, truncated input, and card content. The changelog describes the label and card changes.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: kahme247

Merge Risk: ⚪ Minimal · up to 8ae42

Expanded passive context retains its line breaks. No actionable merge-blocking issue remains after normal checks.

Pre-merge checks | Passed 4 | Failed 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 2 files. (2 skipped: 2… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: displaying passive-context wrappers as labelled nested cards.
Full details: Docstring Coverage

Explanation

Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 2 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@andrebrait
andrebrait force-pushed the feat/passive-context-wrapper-card branch from 4fc6959 to 8ae429a Compare October 12, 2026 08:17
@andrebrait

andrebrait commented Oct 12, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@andrebrait

andrebrait commented Oct 12, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown
⚠️ Action not completed

Already reviewed the last commit. Use @coderabbitai full review to rerun a review of the entire changeset.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T08:25:42.713197Z 8ae429a Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 8ae429acd3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@andrebrait
feat(chat): show passive-context wrappers as a labelled nested card
5d5cbc2 
Passive tool context wrapped in a tag (graphify's <system-reminder
source="graphify">, omp's rule reminders) lost the tag name and attribute
keys, so it read as unlabelled text. Title it like developer reminders
(system-reminder · source=graphify) on the collapsed line, and render it
as a nested card with that header when the tool card is expanded.
@andrebrait
refactor(chat): parse the passive-context wrapper once; skip an empty…
767fe20 
… body
@andrebrait
andrebrait force-pushed the feat/passive-context-wrapper-card branch from 8ae429a to 767fe20 Compare October 13, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@andrebrait