[companion] feat(install-name): choose the installation name with OMP_WEB_NAME by andrebrait · Pull Request #86 · andrebrait/ompweb

andrebrait · 2026-10-07T08:19:51Z

Review-only companion to kahme247#227. Identical head and matching upstream base.

Codex and CodeRabbit have current availability evidence on this repository (#85). Upstream is read-only for this account, so review requests go here after upstream CI is green.

Summary by CodeRabbit

New Features
- Added OMP_WEB_NAME to customize the name shown in browser tabs and installed apps. Set a custom value to use it as the name, or use url, host, or domain to use the connected hostname (without its port). For localhost or IP addresses, the hostname option displays omp web.
- The default name remains omp web. Restart the service for name changes to take effect.
- Service installations now preserve the configured name.

Default to omp web again instead of deriving the name from the request. OMP_WEB_NAME=url|host|domain (any case) opts into the Host-derived name; any other non-blank value is used verbatim. Service installers preserve it.

coderabbitai · 2026-10-07T08:20:00Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults
Review profile: CHILL
Plan: Advanced
Run ID: ddd25c74-34ba-4059-b731-90431a0c8dc6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 3c4dab9d-a236-4e16-b279-09d5a1459156

📥 Commits

Reviewing files that changed from the base of the PR and between 6c86c13 and 765c8bf.

📒 Files selected for processing (9)

CHANGELOG.md
README.ja.md
README.md
README.zh-CN.md
bin/omp-web-launchd.js
bin/omp-web-systemd.js
bin/omp-web-systemd.test.mjs
lib/install-name.test.mjs
lib/install-name.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

The change adds OMP_WEB_NAME to control browser-tab and installed-app names. It supports fixed names and hostname-derived names, passes the setting through service installers, and documents the behavior.

Changes

Display-name configuration

Layer / File(s)	Summary
Name selection and documented behavior `lib/install-name.ts`, `lib/install-name.test.mjs`, `README.md`, `README.ja.md`, `README.zh-CN.md`, `CHANGELOG.md`	`getInstallName` uses `omp web` when `OMP_WEB_NAME` is unset or blank. Values `url`, `host`, and `domain` derive the name from Host; other values are used as the configured name. Tests and documentation describe hostname validation, defaults, and restart requirements.
Service installer environment propagation `bin/omp-web-launchd.js`, `bin/omp-web-systemd.js`, `bin/omp-web-systemd.test.mjs`	The launchd and systemd installers add a truthy `OMP_WEB_NAME` value to their generated environments. The systemd install test verifies the value is preserved.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: lalondesteve, kahme247

Merge Risk: 🔵 Low · up to 765c8

Names with unusual whitespace may display differently than the documentation promises. Ordinary names are unaffected, so this is a bounded follow-up rather than a merge blocker.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 5 files. (4 skipped: 4…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: using OMP_WEB_NAME to choose the installation name.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 5 files. (4 skipped: 4 unsupported.)

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

andrebrait · 2026-10-07T08:25:24Z

@codex review

andrebrait · 2026-10-07T08:25:26Z

@coderabbitai review

coderabbitai · 2026-10-07T08:25:33Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

chatgpt-codex-connector · 2026-10-07T08:25:43Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-07T08:28:33.965644Z	`765c8bf`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector · 2026-10-07T08:28:32Z

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 765c8bfc01

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

docs: note how OMP_WEB_NAME affects installed app names

a4222c0

andrebrait mentioned this pull request Oct 8, 2026

[companion] feat(auth): skip the password for requests a trusted proxy vouches for #91

Open

Navigation Menu

Repository navigation

[companion] feat(install-name): choose the installation name with OMP_WEB_NAME - #86

[companion] feat(install-name): choose the installation name with OMP_WEB_NAME#86
andrebrait wants to merge 2 commits into
companion/omp-web-name-basefrom
feat/omp-web-name

andrebrait commented Oct 7, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Oct 7, 2026 •

edited

Loading

Review skipped

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

andrebrait commented Oct 7, 2026

Uh oh!

andrebrait commented Oct 7, 2026

Uh oh!

coderabbitai Bot commented Oct 7, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot commented Oct 7, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot commented Oct 7, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

andrebrait commented Oct 7, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

andrebrait commented Oct 7, 2026

Uh oh!

andrebrait commented Oct 7, 2026

Uh oh!

coderabbitai Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot commented Oct 7, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

andrebrait commented Oct 7, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Oct 7, 2026 •

edited

Loading

coderabbitai Bot commented Oct 7, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 7, 2026 •

edited

Loading