Skip to content

Make subscription feed retention configurable #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andreasmolnardev merged 1 commit into from
Sep 2, 2026
Merged

Make subscription feed retention configurable #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/backend/src/jobs/news/feed-builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import {
writeMaterializedFeed,
writeSubscriptionArticles,
} from "../../lib/cache/feed-items";
import { config } from "../../lib/config";
import { createLogger } from "../../lib/logger";
import { getFeedItems } from "./helper";
import type { NewsFeedItem } from "@dashwise/types/sdk";
Expand All @@ -40,7 +41,6 @@ export type NewsFeedRecord = {
type BuilderOptions = { userId?: string; feedIds?: string[] };

const logger = createLogger("NewsFeedBuilder");
const SUBSCRIPTION_RETENTION = 500;

function itemTime(item: Record<string, unknown>) {
const value = item.pubDate;
Expand Down Expand Up @@ -97,7 +97,7 @@ async function fetchAndCacheSubscription(subscription: NewsSubscription, result:
try {
const raw = await getFeedItems({
feedUrl,
maxItems: SUBSCRIPTION_RETENTION,
maxItems: config.NEWS_SUBSCRIPTION_RETENTION,
feedName: subscription.title || feedUrl,
linkReplaceRule: subscription.linkReplaceRule,
thumbnailOverwriteUrl: subscription.thumbnailOverwriteUrl,
Expand Down
1 change: 1 addition & 0 deletions apps/backend/src/jobs/news/helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ export async function getFeedItems({
} as FeedItem;
})
.filter((item: FeedItem) => !isNaN(item.pubDate.getTime()))
.sort((left: FeedItem, right: FeedItem) => right.pubDate.getTime() - left.pubDate.getTime())
.slice(0, maxItems);
}

Expand Down
5 changes: 5 additions & 0 deletions apps/backend/src/lib/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ const fallbackOutlierValue = normalizedOutlierType === "absolute" ? 500 : 50;
const resolvedOutlierValue = Number.isFinite(normalizedOutlierValue) && normalizedOutlierValue > 0
? normalizedOutlierValue
: fallbackOutlierValue;
const normalizedNewsSubscriptionRetention = Number(env.NEWS_SUBSCRIPTION_RETENTION);
const resolvedNewsSubscriptionRetention = Number.isInteger(normalizedNewsSubscriptionRetention) && normalizedNewsSubscriptionRetention > 0
? normalizedNewsSubscriptionRetention
: 50;

const truthyEnv = (value?: string | null): boolean => {
if (!value) return false;
Expand Down Expand Up @@ -61,6 +65,7 @@ export const config = {
MONITORING_RUNNER_SCHEDULE: env.MONITORING_RUNNER_SCHEDULE || "*/1 * * * *",
UPDATE_CHECK_SCHEDULE: env.UPDATE_CHECK_SCHEDULE || "0 2 * * *",
FEED_BUILDING_SCHEDULE: env.FEED_BUILDING_SCHEDULE || "*/30 * * * *",
NEWS_SUBSCRIPTION_RETENTION: resolvedNewsSubscriptionRetention,
NOTIFICATION_FORWARDER_SCHEDULE: env.NOTIFICATION_FORWARDER_SCHEDULE || "* * * * *",
DEFAULT_INTEGRATIONS_SCHEDULE: env.DEFAULT_INTEGRATIONS_SCHEDULE || "0 4 * * *",
PAGECONFIG_CLEANUP_SCHEDULE: env.PAGECONFIG_CLEANUP_SCHEDULE || "0 5 * * *",
Expand Down
1 change: 1 addition & 0 deletions docs/Configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ You can use the following environment variables for the all-in-one container; th
| MONITORING_RUNNER_SCHEDULE | No | `*/1 * * * *` | How often the monitoring runner executes |
| UPDATE_CHECK_SCHEDULE | No | `0 2 * * *` | Schedule for update check job |
| FEED_BUILDING_SCHEDULE | No | `*/30 * * * *` | Schedule for news feed building job |
| NEWS_SUBSCRIPTION_RETENTION | No | `50` | Maximum number of latest articles retrieved and cached per news subscription |
| NOTIFICATION_FORWARDER_SCHEDULE | No | `* * * * *` | Schedule for notification forwarder job |
| DEFAULT_INTEGRATIONS_SCHEDULE | No | `0 4 * * *` | Schedule for default integrations sync |
| PAGECONFIG_CLEANUP_SCHEDULE | No | - | Deprecated/no-op. Page-config cleanup runs immediately when an integration is deleted; this variable is read for compatibility but does not schedule work. |
Expand Down
Loading