Multiple Workspaces don't work

[Haadi-Khan]

After clicking Add Workspace, it directs me to the browser. After opening the slack link in slacky, it opens a new window which only has the original workspace. The main window also does not gain a new workspace.

[andirsun]

Thanks for reporting this. Yeah I have to find a way to redirect the browser window with the new workspace to the app.
I will look into it when I have some time.

[miurahr]

I think Slaky should open new browser window IN the slack process when target URL is slack.com.
Slacky always return "deny" for opening URL, but it should check schema or uri to open it in external web browser or internal web browser.

current

    /**
     * Open links in the default browser
     */
    Main.mainWindow.webContents.setWindowOpenHandler(({url}) => {
      void shell.openExternal(url)
      // We need to return 'deny' in order to not open a new electron window
      // Works like e.preventDefault()
      return {action: 'deny'}
    })

can be something like

    /**
     * Open links in the default browser except for slack.com operations.
     */
    Main.mainWindow.webContents.setWindowOpenHandler(({url}) => {
      if (url.includes('slack.com')) {
         // Open the URL in the internal web browser
         void Main.mainWindow.loadURL(url)
       } else {
          void shell.openExternal(url)
      }
      // We need to return 'deny' in order to not open a new electron window
      // Works like e.preventDefault()
    return {action: 'deny'}
    })

[miurahr]

This is complete example;

    /**
     * Open links in the default browser except for slack.com operations.
     */
    Main.mainWindow.webContents.setWindowOpenHandler(({ url }) => {
      if (url.includes('slack.com')) {
        // Open if URL belongs to slack.com
        return { action: 'allow' }
      } else {
        // Open external links in the system's default browser
        shell.openExternal(url)
        return { action: 'deny' } // Deny Electron from opening new windows directly
      }
    })

    // Intercept link navigation within the page
    Main.mainWindow.webContents.on('will-navigate', (event, url) => {
      if (!url.includes('slack.com')) {
        event.preventDefault() // Prevent navigation
        shell.openExternal(url) // Open in external OS browser
        return { action: 'deny' }
      }
      return { action: 'allow' }
    })

[miurahr]

We also may need to enhance WebRequest sessions override userAgents.

There is a library to do it.
https://www.npmjs.com/package/electron-better-web-request

This is a sample script to override the WebRequest session with custom userAgent

import { Session, OnBeforeSendHeadersListenerDetails, BeforeSendResponse } from 'electron'
import enhanceWebRequest from 'electron-better-web-request'

// TODO: Fix this hacky way to get around Slack's user agent check
const defaultUserAgent = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/129.0.0.0 Safari/537.36'

const enhanceSession = (session: Session) => {
  enhanceWebRequest(session)
  session.setUserAgent(defaultUserAgent)
  session.webRequest.onBeforeSendHeaders(
    (details: OnBeforeSendHeadersListenerDetails, callback: (beforeSendResponse: BeforeSendResponse) => void) => {
      details.requestHeaders['User-Agent'] = defaultUserAgent
      details.requestHeaders['Referer'] = details.referrer
      callback({
        cancel: false,
        requestHeaders: details.requestHeaders
      })
    }
  )
}

and then main.ts#main can have a snippet;

    app.on('session-created', (session) => {
      enhanceSession(session)
    })

[miurahr]

When working on multiple workispaces, I want to use workspace switcher.
Please find a stack exchange thread discussing user agent for slack.com We can change UA string with "(Slack)".

[peterdk]

Nice, looking forward to this. Though, might be better to actually check hostname to be slack.com instead of matching in full url, just to catch weird bugs.

[andirsun]

I am going to check the PR this week and tested it on my laptop before approval. Thanks for the help guys!

[overengineeredit]

I'm also experience this issue on release 0.0.6.