Skip to content

[TASK] Require pluswerk/grumphp-config 11.4 and remove the PHP 8.6 workaround - #95

Merged
Kanti merged 4 commits into
masterfrom
remove-php86-workaround
Nov 20, 2026
Merged

Kanti merged 4 commits into
masterfrom
remove-php86-workaround

Conversation

@Kanti

@Kanti Kanti commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

pluswerk/grumphp-config 11.4.0 (released 2026-11-20, with phpro/grumphp 2.27.0) is the first version that allows PHP 8.6. No 10.x release does, so this PR requires 11.4 and removes the PHP 8.6 workaround from CI completely.

Changes

  • composer.json: pluswerk/grumphp-config ^10.2.9 → ^11.4.0 (grumphp-config 11 requires PHP 8.2, this extension requires PHP 8.3 or newer).
  • composer.json: allow the Composer plugin a9f/fractor-extension-installer. grumphp-config 11 installs Fractor, and Composer refuses to run a plugin that is not in allow-plugins in CI.
  • .github/workflows/tasks.yml: remove the PHP 8.6 workaround: the matrix include entry with --ignore-platform-req=php+, the ${{ matrix.ignorePlatformReqs }} references on composer require and composer install, the composer check-platform-reqs --no-dev step and the related comments. All legs now run the same commands.

Lint fixes

Fractor (new in grumphp-config 11) reformats XML and XLIFF files (CodeFormatRule). Applied with fractor process in a separate commit, whitespace only, the content stays the same:

  • Resources/Private/Language/de.locallang_db.xlf
  • Resources/Private/Language/locallang_db.xlf
  • phpunit.xml

Rector and PHPStan of grumphp-config 11.4 needed no changes. There is no composer.lock in this repository.

Result

All legs are green, PHP 8.3 to 8.6 with TYPO3 13, GrumPHP and the tests, without ignoring any platform requirement: https://github.com/andersundsehr/mail_logger/actions/runs/44729924149

phpro/grumphp 2.27.0 and pluswerk/grumphp-config 11.4.0 allow PHP 8.6, so Composer no longer needs --ignore-platform-req=php+.
composer.json allows pluswerk/grumphp-config ^10.2.9, and no 10.x release allows PHP 8.6 (10.2.10 requires ~8.2.0 || ~8.3.0 || ~8.4.0 || ~8.5.0). Without --ignore-platform-req=php+ the PHP 8.6 leg can not be resolved, so keep it there and name the dependency that needs it. The other legs never used the flag.
…rkaround

pluswerk/grumphp-config 11.4.0 is the first version that allows PHP 8.6,
so Composer no longer has to ignore the PHP requirement on the PHP 8.6 leg.
grumphp-config 11 installs Fractor, so its Composer plugin
a9f/fractor-extension-installer is allowed as well.
Fractor from pluswerk/grumphp-config 11 reformats XML and XLIFF files.
Only whitespace changes, the content stays the same.
@Kanti
Kanti marked this pull request as ready for review November 20, 2026 11:45
@Kanti
Kanti merged commit 6e223f6 into master Nov 20, 2026
10 checks passed
@Kanti
Kanti deleted the remove-php86-workaround branch November 20, 2026 11:45
@Kanti Kanti changed the title [TASK] Remove the PHP 8.6 workaround for GrumPHP [TASK] Require pluswerk/grumphp-config 11.4 and remove the PHP 8.6 workaround Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant