Repository navigation
[TASK] Require pluswerk/grumphp-config 11.4 and remove the PHP 8.6 workaround - #95
Merged
Merged
Conversation
phpro/grumphp 2.27.0 and pluswerk/grumphp-config 11.4.0 allow PHP 8.6, so Composer no longer needs --ignore-platform-req=php+.
composer.json allows pluswerk/grumphp-config ^10.2.9, and no 10.x release allows PHP 8.6 (10.2.10 requires ~8.2.0 || ~8.3.0 || ~8.4.0 || ~8.5.0). Without --ignore-platform-req=php+ the PHP 8.6 leg can not be resolved, so keep it there and name the dependency that needs it. The other legs never used the flag.
…rkaround pluswerk/grumphp-config 11.4.0 is the first version that allows PHP 8.6, so Composer no longer has to ignore the PHP requirement on the PHP 8.6 leg. grumphp-config 11 installs Fractor, so its Composer plugin a9f/fractor-extension-installer is allowed as well.
Fractor from pluswerk/grumphp-config 11 reformats XML and XLIFF files. Only whitespace changes, the content stays the same.
Kanti
marked this pull request as ready for review
November 20, 2026 11:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pluswerk/grumphp-config 11.4.0 (released 2026-11-20, with phpro/grumphp 2.27.0) is the first version that allows PHP 8.6. No 10.x release does, so this PR requires 11.4 and removes the PHP 8.6 workaround from CI completely.
Changes
composer.json:pluswerk/grumphp-config^10.2.9→^11.4.0(grumphp-config 11 requires PHP 8.2, this extension requires PHP 8.3 or newer).composer.json: allow the Composer plugina9f/fractor-extension-installer. grumphp-config 11 installs Fractor, and Composer refuses to run a plugin that is not inallow-pluginsin CI..github/workflows/tasks.yml: remove the PHP 8.6 workaround: the matrixincludeentry with--ignore-platform-req=php+, the${{ matrix.ignorePlatformReqs }}references oncomposer requireandcomposer install, thecomposer check-platform-reqs --no-devstep and the related comments. All legs now run the same commands.Lint fixes
Fractor (new in grumphp-config 11) reformats XML and XLIFF files (
CodeFormatRule). Applied withfractor processin a separate commit, whitespace only, the content stays the same:Resources/Private/Language/de.locallang_db.xlfResources/Private/Language/locallang_db.xlfphpunit.xmlRector and PHPStan of grumphp-config 11.4 needed no changes. There is no
composer.lockin this repository.Result
All legs are green, PHP 8.3 to 8.6 with TYPO3 13, GrumPHP and the tests, without ignoring any platform requirement: https://github.com/andersundsehr/mail_logger/actions/runs/44729924149