Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.6.0 was released on 2026-11-19.
Changes
~8.6.0in thephpconstraint ofcomposer.json.Strict comparison using === between DateTime and false will always evaluate to falseinMailLogRepository.php). Since PHP 8.3,DateTime::modify()throws instead of returning false, so the check never ran. The anonymization date is now created withnew DateTime('-' . $anonymizeAfter)in a try/catch; an invalid period still throws theInvalidArgumentException8348363882 on every PHP version.Only dev dependencies skip the PHP check
phpro/grumphp(viapluswerk/grumphp-config) does not allow PHP 8.6 yet: the latest release v2.26.0 requires~8.2.0 || ~8.3.0 || ~8.4.0 || ~8.5.0. So the 8.6 leg runs Composer with--ignore-platform-req=php+.To make sure this only affects dev dependencies, the 8.6 leg also runs
composer check-platform-reqs --no-dev. It fails if a non-dev dependency does not allow PHP 8.6.Once GrumPHP allows PHP 8.6,
ignorePlatformReqscan be removed from the workflow.Result
✅ All legs are green, including PHP 8.6 and the platform check: https://github.com/andersundsehr/mail_logger/actions/runs/44596263661