Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Minor maintenance updates in cortexadb-core, primarily focused on formatting/cleanliness of exports and imports within the core modules.
Changes:
- Reformats facade re-exports in
lib.rsfor readability. - Normalizes module import paths in
core(e.g.,crate::core::...) and removes trailing whitespace in a doc comment. - Removes the
MemoryIdordering unit test frommemory_entry.rs.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crates/cortexadb-core/src/lib.rs | Re-formats facade re-export block. |
| crates/cortexadb-core/src/engine.rs | Doc comment whitespace cleanup. |
| crates/cortexadb-core/src/core/state_machine.rs | Updates imports to use crate::core::{...}. |
| crates/cortexadb-core/src/core/memory_entry.rs | Removes MemoryId ordering test. |
| crates/cortexadb-core/src/core/command.rs | Consolidates imports for MemoryEntry/MemoryId. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -65,11 +65,4 @@ mod tests { | |||
| assert_eq!(entry.importance, 0.8); | |||
| assert_eq!(entry.embedding, Some(vec![0.1, 0.2, 0.3])); | |||
| } | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.