Skip to content

Add windows#36

Merged
anaslimem merged 4 commits intomainfrom
add-windows
Apr 16, 2026
Merged

Add windows#36
anaslimem merged 4 commits intomainfrom
add-windows

Conversation

@anaslimem
Copy link
Copy Markdown
Owner

added windows patch

Copilot AI review requested due to automatic review settings April 16, 2026 22:11
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cortexa-db Ready Ready Preview, Comment Apr 16, 2026 10:11pm

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the project to v1.0.1 while extending the release workflow to build and publish wheels for Windows in addition to Linux/macOS.

Changes:

  • Add windows-latest to the GitHub Actions release matrix and adjust PyPI publish behavior.
  • Bump versions across Rust crates, Python packaging metadata, and documentation from 1.0.0 (and 0.1.8 for cortexadb-py) to 1.0.1.
  • Update the usearch dependency to 2.25.1 (and refresh Cargo.lock accordingly).

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
docs/resources/benchmarks.md Updates benchmark doc version reference to v1.0.1.
crates/cortexadb-py/pyproject.toml Bumps Python package version to 1.0.1.
crates/cortexadb-py/Cargo.toml Bumps Rust crate version to 1.0.1.
crates/cortexadb-core/Cargo.toml Bumps core crate version and updates usearch dependency version.
README.md Updates displayed version strings/badges to 1.0.1.
Cargo.lock Reflects new crate versions and updated dependency graph (usearch + new transitive deps).
.github/workflows/release.yml Adds Windows to wheel build matrix and tweaks publishing inputs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 16 to +18
strategy:
matrix:
os: [ubuntu-latest, macos-latest]
os: [ubuntu-latest, macos-latest, windows-latest]
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maturin-action is passed target: ${{ matrix.target }}, but the job matrix only defines os (no target). This makes the workflow brittle (the expression may resolve to an empty/undefined value) and can break wheel builds—especially now that Windows was added. Either add a target entry per matrix item (e.g., via matrix.include) or remove the target: input to let maturin pick the default for each runner.

Copilot uses AI. Check for mistakes.
@anaslimem anaslimem merged commit 6cba478 into main Apr 16, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants