Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR updates the project to v1.0.1 while extending the release workflow to build and publish wheels for Windows in addition to Linux/macOS.
Changes:
- Add
windows-latestto the GitHub Actions release matrix and adjust PyPI publish behavior. - Bump versions across Rust crates, Python packaging metadata, and documentation from 1.0.0 (and 0.1.8 for
cortexadb-py) to 1.0.1. - Update the
usearchdependency to 2.25.1 (and refreshCargo.lockaccordingly).
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/resources/benchmarks.md | Updates benchmark doc version reference to v1.0.1. |
| crates/cortexadb-py/pyproject.toml | Bumps Python package version to 1.0.1. |
| crates/cortexadb-py/Cargo.toml | Bumps Rust crate version to 1.0.1. |
| crates/cortexadb-core/Cargo.toml | Bumps core crate version and updates usearch dependency version. |
| README.md | Updates displayed version strings/badges to 1.0.1. |
| Cargo.lock | Reflects new crate versions and updated dependency graph (usearch + new transitive deps). |
| .github/workflows/release.yml | Adds Windows to wheel build matrix and tweaks publishing inputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest, macos-latest] | ||
| os: [ubuntu-latest, macos-latest, windows-latest] |
There was a problem hiding this comment.
maturin-action is passed target: ${{ matrix.target }}, but the job matrix only defines os (no target). This makes the workflow brittle (the expression may resolve to an empty/undefined value) and can break wheel builds—especially now that Windows was added. Either add a target entry per matrix item (e.g., via matrix.include) or remove the target: input to let maturin pick the default for each runner.
added windows patch