Feature/modernize#11
Draft
Chris53897 wants to merge 11 commits into
Draft
Conversation
Owner
|
Hi @Chris53897 thanks for contributing to the this project, actually I do not use this bundle a long time ago. I was checking your changes, there are a lot of updated files. I will continue checking all the changes. I will post a more technically explanation about how it works, but it will take some days, I'm stuck at work right now. |
Author
|
@anacona16 Thanks for the reply. Take your time, no need for hussle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. I made some changes to keep this good idea alive for newer symfony versions.
There is still some work left.
I have created a first draft for a demo.
https://github.com/Chris53897/ImageCropBundleDemo
I did not use the bundle before, so i would be glad for some input from you.
My main question is: How is the Crop saved?
I do not see andy save button.
Changelog:
Dropped Support for PHP < 8
Dropped Support for Symfony < 4.4
Add Support for Symfony 4,5,6
Started to add Unittests
Add the missing symfony components to composer
Changed directory /web/ to /public/ The default Folder for symfony 4 and symfony flex