Draft
Conversation
- Create guides-footer-tracking.js with DOM event delegation solution - Add comprehensive documentation (README and specification) - Include interactive example HTML demo - Add unit tests for footer tracking functionality - Document investigation findings and required source code changes This provides a client-side workaround for tracking clicks on the 'Powered by Amplitude' footer while the source repository for @amplitude/engagement-browser is located for a proper fix. Co-authored-by: Lucas Howard <lchoward@users.noreply.github.com>
- Provide step-by-step deployment instructions - Include both workaround and proper source fix approaches - Add testing checklist and success metrics Co-authored-by: Lucas Howard <lchoward@users.noreply.github.com>
- Outline immediate actions for deploying workaround - Document steps to locate source repository - Provide decision framework for deployment approach - List all deliverables in this branch Co-authored-by: Lucas Howard <lchoward@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
- Remove unused mockDocument and mockWindow variables - Remove unused event parameter in click listener - Fixes ESLint violations in CI Co-authored-by: Lucas Howard <lchoward@users.noreply.github.com>
Document resolution of ESLint issues and required PR title change Co-authored-by: Lucas Howard <lchoward@users.noreply.github.com>
Provide clear steps for manually updating PR title to pass CI checks Co-authored-by: Lucas Howard <lchoward@users.noreply.github.com>
Co-authored-by: Lucas Howard <lchoward@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements click tracking for the "Powered by Amplitude" footer displayed in Amplitude guides and surveys. As the footer's source code (
@amplitude/engagement-browser) is in a private repository, a direct modification was not feasible. This solution provides a standalone JavaScript plugin that uses DOM event delegation to trackGuides Footer Clickedevents, including relevant properties. The PR also includes comprehensive documentation, an example, and unit tests to facilitate immediate deployment as a workaround.Checklist
Slack Thread