Repair 16 comprehensive fixture patches and add a patch-apply CI check (#541) - #542
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #541
What
input.patchdid not apply to their owninput.base(wrong hunk-header counts, drifted context/indentation, and missing base files inrisk-depth-diffsize-elevated-refactor). Addstest_benchmark_corpus_patch_applies.py, a corpus-widegit applysweep through the runner's own patch materialization, so drift fails in CI instead of a scheduled run._materialize_patch/_PatchDidNotApplybecome publicmaterialize_patch/PatchDidNotApply(no behavior change). Patch-apply validation and fail-closed completion verification are unchanged; no case is skipped or excluded.CHANGELOG.md(seedocs/RELEASE.md)Validation
git apply --checksweep: 16 failures before, 0 after.materialize_patchpath (108/108).run_benchmark.py --case-idpath, allexecuted, nopatch-did-not-apply:database-migration-deepening-additive-nullable-column-clean(the triggering hunk-header fixture),database-migration-deepening-expand-contract-safe-clean(context/start-line),risk-depth-diffsize-elevated-refactor(missing base files),semantic-implication-single-dimension-persistence(other sub-corpus). Two more repaired fixtures also ran cleanly before the sample was cut short.git applyagainst their own base (fail-closed, blocks lane sealing) #541's acceptance criterion is updated to say so. Edited fixtures get new per-case digests, treated as per-caseincomparable.Review
local-code-reviewon51dbe10: REVIEW CLEAN, 0 P0/P1/P2 (an earlier pass's two P2s were fixed in that commit).🤖 Generated with Claude Code