Silence compiler and clippy warnings…#254
Merged
bors[bot] merged 1 commit intoamethyst:masterfrom Apr 7, 2021
Merged
Conversation
Contributor
Author
|
#249, #250, #251, #252 and #255 failed CI due to compiler warnings (which this PR silenced), not actual problems. For the last two of them it is even worse, because it is failed beta that cancelled almost all other tests, not just failed nightly. |
Collaborator
|
These PRs are only failing CI on nightly (which we allow). New checks added to nightly clippy can happen without warning and will cause spurious CI failures. We should probably remove clippy from the nightly builds in CI. |
Collaborator
|
bors r+ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
… by doing what compiler and clippy say to do.
Motivation and Context
I don't like seeing warnings.
How Has This Been Tested?
cargo +nightly clippy && cargo test
Checklist: