Repository navigation
Decode dictionary keys once at the deserialization boundary instead of in every consumer - #21
Merged
Merged
Conversation
…e raw-array key arms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dictionary keys admitted a raw
array(the un-decoded PROV-JSON{"$":...,"type":...}shape), so every consumer re-decoded them andkeySignature()did it via a helper that silently mis-signed non-xsd/prov prefixes.Now keys are decoded once, at deserialization:
DictionaryEntry::$keyandDictionaryRemoval::$removedKeystoQualifiedName|Literal|string|int|float|bool(no rawarray).JsonSerializerroutes every array-shaped key throughdeserializeTypedValue(), so a malformed typed-literal throwsDeserializationExceptioninstead of leaking downstream.array-handling branches inkeySignature()(andexpandDatatypePrefix()),formatDictKey(),addDictKeyEntitySet()/addDictKeySet(), andremapDictKey().Well-formed input is unchanged; malformed keys now fail loudly at parse time.