fix(ai-enhancer): guard ruleBasedDescription against empty words (crashes on PascalCase names)#1
Open
louisdurden wants to merge 1 commit into
Open
Conversation
PascalCase or all-caps tool names (e.g. "GET", "createPatient") begin
with an uppercase letter, so name.replace(/([A-Z])/g, ' $1') prepends a
leading space. .split(' ') then yields a leading '' element, and
words.map((w,i) => i===0 ? w[0].toUpperCase()... ) throws
"Cannot read properties of undefined (reading 'toUpperCase')".
Trim before splitting and filter empties so `words` never contains an
empty string. Reproduces on any codebase with PascalCase exports
(e.g. a Next.js App Router project), crashing `analyze` after the tool
surface has already been computed.
|
@louisdurden is attempting to deploy a commit to the Amarnath's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
analyzecrashes during description generation on any codebase that exports PascalCase or all-caps identifiers:The crash happens after the full tool surface is computed (backend actions, DB ops, workflows all succeed), so the whole analysis is lost at the last step.
Root cause
In
packages/ai-enhancer/src/index.ts,ruleBasedDescription:When
namestarts with an uppercase letter (e.g.GET,createPatient,useSoapSign), the regex prepends a leading space, sosplit(' ')produces a leading empty-string element. The final line then doesw[0].toUpperCase()on'', and''[0]isundefined.Fix
Trim before splitting and drop empty tokens so
wordsnever contains an empty string:Repro
Run
analyzeagainst any project with PascalCase exports (a Next.js App Router app reproduces it reliably — hundreds ofroute.ts/ component exports). Before: crash. After: completes and emits descriptions normally.