This repository was archived by the owner on Dec 31, 2020. It is now read-only.
Fix for Issue "Optional loading of JQuery and JQuery-ui #13"#14
Open
rlsutton1 wants to merge 3 commits intoalump:masterfrom
Open
Fix for Issue "Optional loading of JQuery and JQuery-ui #13"#14rlsutton1 wants to merge 3 commits intoalump:masterfrom
rlsutton1 wants to merge 3 commits intoalump:masterfrom
Conversation
This fix maintains backwards compatibility of the API. GridStackLayout works exactly as before. Users needing to suppress the loading of JQuery and JQuery-UI should use GridStackLayoutNoJQuery rather than GridStackLayout. changes: I have renamed GridStackLayout to GridStackLayoutNoJQuery and removed the references to jquery and jquery-ui in the @javascript annotation I have created a replacement GridStackLayout which extends GridStackLayoutNoJQuery and has an @javascript annotation which loads the jquery and jquery-ui as before. All other changes are very minimal, referencing GridStackLayoutNoJQuery where necessary.
Owner
|
I have to review this later, there are few things I might do differently. |
Owner
|
Have to fist check if I could pair this to code somehow: https://api.jquery.com/jquery.noconflict/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix maintains backwards compatibility of the API.
GridStackLayout works exactly as before.
Users needing to suppress the loading of JQuery and JQuery-UI should use
GridStackLayoutNoJQuery rather than GridStackLayout.
changes:
I have renamed GridStackLayout to GridStackLayoutNoJQuery and removed
the references to jquery and jquery-ui in the @javascript annotation
I have created a replacement GridStackLayout which extends
GridStackLayoutNoJQuery and has an @javascript annotation which loads
the jquery and jquery-ui as before.
All other changes are very minimal, referencing GridStackLayoutNoJQuery
where necessary.