Skip to content

fix: show works with kakoune#526

Merged
altsem merged 1 commit intoaltsem:masterfrom
evnoj:kak-line-support
Apr 23, 2026
Merged

fix: show works with kakoune#526
altsem merged 1 commit intoaltsem:masterfrom
evnoj:kak-line-support

Conversation

@evnoj
Copy link
Copy Markdown
Contributor

@evnoj evnoj commented Apr 22, 2026

kakoune uses the kak +<line> <file> syntax to open a file to a line. When running kak <file>:<line>, it thinks that you are trying to open a file named <file>:<line>. Since this file almost certainly does not exist, it opens an empty buffer. This commit just adds kakoune to the hardcoded list of editors with the +<line> syntax.

Checklist

  • The modified code has some test-coverage (where applicable).
    • Test coverage did not seem applicable here, there are not currently tests for each editor in the modified conditional check, just tests that ensure lowercasing and argument parsing work correctly, which are unchanged.
  • make test is passing (this is what CI runs).
    • It's actually not all passing on my machine, cargo clippy -- -Dwarnings is failing due to something in src/picker.rs that is unrelated to this change. This failure is not introduced by this change, it is present in the current master (a887673). Seems like it is passing on CI though.
  • New unreleased features/fixes/styling and performance improvements are documented via git: feat: / fix: / style: / perf:. Or e.g. perf(highlighting):.
    See https://github.com/altsem/gitu/blob/master/docs/dev-tooling.md

kakoune uses the 'kak +<line> <file>' syntax to open a file to a line. When running 'kak <file>:<line>', it thinks that you are trying to open a file named '<file>:<line>'. Since this file almost certainly does not exist, it opens an empty buffer. This commit just adds kakoune to the hardcoded list of editors with the +<line> syntax.
Copy link
Copy Markdown
Owner

@altsem altsem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :)

@altsem altsem merged commit b03e699 into altsem:master Apr 23, 2026
3 checks passed
@evnoj evnoj deleted the kak-line-support branch April 23, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants