Closed
Conversation
kamilwaz
commented
Apr 13, 2026
| fn open_repo(dir: &Path) -> Res<Repository> { | ||
| log::debug!("Opening repo"); | ||
| let repo = open_repo_from_env()?; | ||
| let mut repo = Repository::open(dir).map_err(Error::OpenRepo)?; |
Contributor
Author
There was a problem hiding this comment.
I replaced open_from_env, as GIT_DIR should already be handled by git rev-parse --show-toplevel.
Contributor
Author
|
I spent some more time on it and it turns out that this is a bug in libgit2. Also, my fix doesn’t actually solve it. In short, the issue is that libgit2 doesn’t correctly handle shallow grafts for worktrees created in a shallow repository. Shallow grafts should be assigned here: However, because libgit2 thinks the repository isn't shallow, it doesn’t set them here: This causes the parent of the latest commit to be returned (as an OID), even though it doesn't exist locally. I’m closing the PR and will try to address this in libgit2 when I get a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I experimented a bit with worktrees and bare repositories and found a bug where
Gitu isn’t able to fetch the history for a worktree created in a bare repository. This PR fixes the issue and makes the tests use the same function to open repositories as regular Gitu.Update: The issue is actually in libgit2; shallow grafts are not set correctly for "shallow" worktrees.
Error:
Checklist
make testis passing (this is what CI runs).feat:/fix:/style:/perf:. Or e.g.perf(highlighting):.See https://github.com/altsem/gitu/blob/master/docs/dev-tooling.md